Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate matching logic adapters #456

Merged
merged 11 commits into from
Dec 3, 2016
Merged

Deprecate matching logic adapters #456

merged 11 commits into from
Dec 3, 2016

Conversation

gunthercox
Copy link
Owner

@gunthercox gunthercox commented Dec 2, 2016 •
edited
Loading

This adds a deprecation warning that will be displayed if certain adapters that extend the BestMatch adapter are used. At this point it is preferred to use the BestMatch adapter and set the comparison_function parameter.

  • Add warning
  • Update imports of deprecated classes
  • Update tests to avoid the deprecated classes
  • Update documentation

Closes #430

@gunthercox gunthercox merged commit eb5c544 into master Dec 3, 2016
@gunthercox gunthercox deleted the docs branch December 3, 2016 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gunthercox